Sunset Lake Software - Comments for "Switching GPUImage to use cached framebuffers"

Hi Brad, very nice

Hi Brad, very nice library.

I'm having trouble to display images on their correct orientation! portrait images are shown on landscape. some landscaped images ar shown flipped upside down.. and i'm not being able to fix it.

i'm using:

- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event {
    UITouch *touch = [touches anyObject];
    CGPoint point = [touch locationInView:self.imageView];
    [self aplicaFiltroNoPonto:point];
}
 
- (void) aplicaFiltroNoPonto:(CGPoint)point {
    if (!primeiroEfeito) {
        loadedImg = [self.capturedImages objectAtIndex:0];
        filteredImg = [bulgeFilter imageByFilteringImage:loadedImg];
        bulgeFilter = [[GPUImageBulgeDistortionFilter alloc] init];
        [bulgeFilter setRadius:0.2];
        [bulgeFilter setScale:0.3];
        [bulgeFilter setShouldSmoothlyScaleOutput:YES];
        CGRect mainScreenFrame = [[UIScreen mainScreen] applicationFrame];
        GPUImageView *primaryView = [[GPUImageView alloc] initWithFrame:mainScreenFrame];
        [bulgeFilter forceProcessingAtSizeRespectingAspectRatio:primaryView.sizeInPixels];
        primeiroEfeito = YES;
    }
 
    [bulgeFilter setCenter:CGPointMake(point.x / self.view.frame.size.width,point.y / self.view.frame.size.height)];
 
    [bulgeFilter useNextFrameForImageCapture];
    filteredImg = [bulgeFilter imageByFilteringImage:loadedImg];
    [self.imageView setImage:filteredImg];
}

setCenter is not working because the image is being processed in the wrong orientation :/

any ideas?

Brad, I'm having trouble

Brad,
I'm having trouble with the latest source code. I'm trying to apply some filtering on videos. I'm getting strange results. At first I thought it was my code. So I decided to use your stock examples from the examples directory. I'm seeing the same errors(?) in the sample applications (for iOS). Using the SimpleFileVideoFilter example, I run the code in the simulator and the referenced video contained in your source is all distorted when it gets rendered to the screen. The output file is not readable by Quicktime on my Macbook. Nor can I upload it to YouTube. Am I missing something?

This is really vexing since I'm working on a project that depends on some openGLES manipulations but I couldn't get GLKit to do what I wanted and was going to try GPUImage, but I've hit this roadblock.

Thanks,
Mike

Hi Brad, really enjoying the

Hi Brad, really enjoying the library. I am working on a generic rendering pipeline for a video editing application and using your GPUImage library as the main framework for processing the frames including blending layers, doing filters, etc.

I thought it would be nice to be able to cache the framebuffers in certain locations of the rendering pipeline if the chain above it ends up not changing for a while. (For instance if one layer has a still image with many filters applied and that gets blended with a video, I don't want to have to recalculate the filtered image every frame).

What is the best way to do that with this new system? Would I GPUImageTextureOutput or RawDataOutput to make a copy of the framebuffer. Thanks!

Yeah, that was a callback

Yeah, that was a callback from my failed attempt to conserve memory before this rearchitecting. It caused all kinds of problems in practice, and was no longer needed, so I ditched it. There most likely are other ways to achieve what you were doing before, and if there aren't, create an issue on GitHub to ask about it.

It seems you also got rid of

It seems you also got rid of GPUImageTextureDelegate

I was using that protocol in a few of my custom filters...